User "Krinkle" changed the status of MediaWiki.r86305.

Old Status: new
New Status: fixme

User "Krinkle" also posted a comment on MediaWiki.r86305.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c21396
Commit summary:

Followup r86088 per CR: Move month array builder into language; use 
mw.config.get(); Fix rowspans and some cleanup

Comment:

Marking fixme. tableSorterCollation isn't set anywhere (other than in the unit 
test). A grep search didn't return any call to mw.config.set and/or an array 
property in PHP's config vars for "tableSorterCollation". Where is it coming 
from or should the function using <code> tableSorterCollation</code> be 
refactored ?

The rest of the revision is either fine or has been fixed in the mean time. 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to