User "Krinkle" changed the status of MediaWiki.r92054.

Old Status: new
New Status: fixme

User "Krinkle" also posted a comment on MediaWiki.r92054.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92054#c21406
Commit summary:

Render category links as an HTML list. Bug 12261. Based on patch by Thana & 
Bergi. It's removing the textual  pipe separator, wrapping the links inside li 
elements and adding a left 1px border as separator. This makes it much easier 
to manipulate the list via JS or CSS and is also semantically correct

Comment:

This revision introduces an issue.

The <code><nowiki><div id="catlinks"></nowiki></code> are outputted form within 
the skin-implementations (ie. ColongneBlue.php), but that ID is styled from 
<code>common.css</code>, please centralize that output so that the ID-naming is 
the same acros skins (or move the styling to skin's stylesheet). 

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to