User "Brion VIBBER" posted a comment on MediaWiki.r95332. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95332#c21431 Commit summary:
* (bug 30441) getParamValue must understand "+" encoding of space $.param() produces query string form encoding using the traditional '+' encoding for space; mediawiki.util.getParamValue() was using only decodeURIComponent() to do unescaping, which is not required by spec to handle '+'. Explicitly replacing '+' with '%20' before the decode nicely resolves this. Added a test case to qunit tests for mediawiki.util module. Comment: Good catch! I'll add another test case and fix it up. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
