User "Catrope" changed the status of MediaWiki.r85951. Old Status: new New Status: resolved
User "Catrope" also posted a comment on MediaWiki.r85951. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85951#c21447 Commit summary: Implement user-is-blocked and wiki-is-read-only as exceptions. Comment: $user->mBlock was already being accessed by the same function under the same circumstances. This revision does not change this at all. You're right that it sucks and should be rewritten to use an accessor (which was attempted in r93237 and reverted due to breaking tests) but it's unrelated to the merits of this revision. Marking resolved because this is fine other than that UserBlockedError makes Chad feel icky, Brion raised a good but unrelated point and there was a typo in a message key that was fixed in r93303. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
