User "Khorn (WMF)" posted a comment on Wikimedia.r421.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/421#c21473
Commit summary:

Now printing raw $msg from queue when pulling from pending_paypal queue rather 
than try and json_decode it (since it's not actually a json object...).  This 
/used/ to happen in production, although it appears to have stopped at the same 
time we upgrade Grosley, which incidentally is when I re-deployed the IPN 
listener - suggesting that it used to be a live hack >_<  This caused problems 
for the contribution log auditer as it was searching for transaction data from 
the raw json objects contained within the raw message output.  ARGH. So this 
has been going on for about a month now, unnoticed.  Let this be a lesson: DONT 
HACK LIVE unless you're prepared to suffer the consequences.  FML.

Comment:

Looks OK to me.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to