User "MaxSem" posted a comment on MediaWiki.r89483. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89483#c21546 Commit summary:
SQLite-specific dropTable(): works a bit faster because it doesn't need a separate table existence check and does not rely on subtly broken tableExists() which I will fix a bit later Comment: I couldn't reproduce reliably this problem with with tableExists() on temprary tables that caused unit tests to crash - apparently, it was due to lack of DB object persistence. I'll revert this revision if there's someone who thinks that having this override harmful - Aaron, note that IF EXISTS simply repeats in SQL what DatgabaseBase is doing in PHP. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
