User "Krinkle" posted a comment on MediaWiki.r94461.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94461#c21579
Commit summary:

Fix r94429 : Left and right side are still nearly the same color for 7% of the 
population. When I wrote to the list a while ago, no one argued for keeping the 
yellow scheme just because we're used to it. This makes it red/blue, also 
increases the highlight area ands adds a subtle border per Brandon Harris

Comment:

Has this been confirmed at all with actual users for which this fix was needed 
? On that matter, would be a good idea to A/B/C test the above three in general 
for people, that might uncover other problems with our diff-workflow (ie. find 
history page, find out how to compare revisions, and interpret the diff).

Suggest revert and confirmation first. Ideally user testing would take place on 
prototype, but a design that is agreed on on BugZilla pre-commit is good too. 
On bug 11374, Brandon actually suggested later to use green/blue instead of 
brown/blue, the commit jumped the gun, discusion wasn't ready yet.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to