User "Jack Phoenix" posted a comment on MediaWiki.r95816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95816#c21646 Commit summary:
fixed bug 24512 (removed curlreq()) and cleaned up parameters for mwServeCommand() Comment: <pre> + if ( !isset( $response['status']['progress'] ) ) $response['status']['progress'] = 1.00; </pre> Needs more braces. Also, [[Manual:Coding conventions|our coding conventions]] aren't followed here; indentation is wonky (either just spaces or tabs and spaces). Our standard is to use tabs to indent code in most cases (see the coding conventions page for the few exceptions, i.e. vertical alignment). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
