User "Catrope" changed the status of MediaWiki.r95582. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r95582. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95582#c21673 Commit summary: Ability to filter list of users based on their test wiki preference Comment: <pre> + "user_id=p1.up_user AND (p1.up_property=$projectPrefName AND p1.up_value=$projectPrefVal)" );< </pre> This isn't wrong, per se, but you can also use something like: <pre> $query['join_conds']['p1'] = array( 'JOIN', array( 'user_id=p1.up_user', 'p1.up_property' => $projectPrefName, 'p1.up_value' => $projectPrefVal ) ); </pre> (of course you'd have to drop the escaping on <code>$projectPrefName</code> and <code>$projectPrefVal</code> in that case because the Database class will do the escaping for you). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
