User "Tim Starling" changed the status of MediaWiki.r89706. Old Status: ok New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r89706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89706#c21792 Commit summary: Reinstate r79122 (fix for bug 14404), reverting r83868. The real bug seem to have been r86131, fixed in r88902 (1.17) and r88902 (1.18). This is not merged with the r86131 change to Article::getParserOptions() since I don't see the point for the new function yet. Reenabled its test ArticleTablesTest which was disabled in r85618 Comment: The introduction of makeParserOptions() in r86131 does appear to have a point after r89124, and it seems like this revision could benefit from it too, since makeParserOptions(new User) would be a lot more readable than getParserOptions(true). This revision seems to sabotage it, by duplicating its content and exposing it to bit rot, negating the point of moving it out of FlaggedRevs in the first place. The commit message is incorrect, presumably you mean "the real bug seems to have been in r72475". It's true that r72475 broke ChronologyProtector, but this change (i.e. r79122) made the bug a lot worse, causing it to break regular edits rather than just page creations. If there is any problem with ChronologyProtector in the future, then with this change in place, the same severe problem will recur. For users with non-default parser options, this revision will cause the page save time to increase by a factor of two. For instance, it currently takes 40 seconds to parse the Barack Obama article; with this change, users with non-default options will have to wait 40 seconds for the redirect plus 40 seconds for the page view, before they are able to verify their edit and interact with the page. I'm not sure if bug 14404 is severe enough to warrant such a huge hit to apparent site performance. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
