User "Tim Starling" posted a comment on MediaWiki.r88780. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88780#c21790 Commit summary:
* Follow-up r88740: * Fixed parse() arguments in getRevIncludes() * Changed clearTagHook() to avoid preprocessed-xml cache corruption * Check current version cache in getRevIncludes() Comment: Does calling clearTagHook() like that make any difference to performance? It still has to expand the same templates, so I would have thought the parse time would be almost identical. If there is no difference, I would suggest not using it, since you are introducing an unnecessary dependency on details of parser functionality. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
