User "Dantman" posted a comment on MediaWiki.r96015. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96015#c21786 Commit summary:
Pass OutputPage instance to MakeGlobalVariablesScript. Allows extensions to getTitle()->equals( .. ) and add config vars depending on title Comment: Seconded, there's no use for it here. I desperately want to start marking as a fixme any commit adding a new hook with a & that isn't there because the purpose of the hook is to let the hook user alter the contents of the variable. After I look at BeforePageDisplay, our context code, and make a change in the code a few lines below, see the &'s that don't need to be there, and realize what a horrible situation that hook is in. We can add a & to a hook later on if we find a need for a caller to alter the variable. However we cannot remove a & from an existing hook, because by all chances functions defined for those hooks will already be including a & even if they don't use it and if we remove the & from the wfRunHooks calls then a pile of extensions start throwing php warning errors. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
