User "Dantman" posted a comment on MediaWiki.r96167. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96167#c21845 Commit summary:
add page link as $1 in feedback notice message Comment: * I think those "'s should be moved into the message. * The whole hardcoded <a, ?title= is horrid, while were at it by using wfMsg for $linkText doesn't that make 'mobile-frontend-leave-feedback-link-text' end up as html, not text. One of these perhaps: <script lang=php> Linker::link( Title::newFromText( 'MobileFrontend Extension Feedback' ), htmlspecialchars( $linkText ), array( 'target' => '_blank' ) ) Html::element( 'a', array( 'href' => Title::newFromText( 'MobileFrontend Extension Feedback' )->getFullURL(), 'target' => '_blank' ), $linkText ); </script> Actually while I'm at it. Shouldn't 'MobileFrontend Extension Feedback' be given a message of it's own too. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
