User "Krinkle" posted a comment on MediaWiki.r96010. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96010#c21856 Commit summary:
RL2: Refactor GadgetPageList resulting in less code duplication in GadgetHooks * Factor getRowForTitle() out of add(), will be useful for the maintenance script I'm about to commit * Factor the duplicated if-redirect-else logic out into updatePageStatus() ** also use it in the undelete hook, it appears that previously suffered of a bug where undeleting a newer revision on top of an older one making the page a redirect didn't cause it to be unlisted in gadgetpagelist * Add a function isGadgetPage() that checks if a page qualifies for being in the table. Not used anywhere right now but will be used by the maintenance script Comment: <code> isGadgetPage</code> is a bit confusing, as it doesn't mean a page in NS_GADGET. Perhaps a different name ? Something more generic like resource wiki pages thingies ? (since Gadget modules can only contain scripts/styles from NS_GADGET) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
