User "Platonides" posted a comment on MediaWiki.r96025.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96025#c21872
Commit summary:

Add the position of the text to the messages so that
the position can be changed depending on the plural, as requested by Amir in
http://lists.wikimedia.org/pipermail/mediawiki-i18n/2011-August/000338.html

Placing the text after the unit could get funny in cases where there is
more text than just the number and the unit, but it's not a problem for the
parserfunction to fix.

The transformations for ParserFunctions.i18n.php were
On pfunc-convert-unit messages: s/$2/$3/, s/$1/$2/
s/'pfunc-convert-unit-.*' *=> '/\0$1/

Comment:

No. This is intended. $1 will contain the space from the text in the 
parserfunction, so we don't want another space (this was easily noted by the 
parsertests when I initially thought it would be needed).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to