User "Catrope" changed the status of MediaWiki.r95604. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r95604. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95604#c21929 Commit summary: define and use closeAndRename() after last write of xml dump file; convert from popen (child inherits all open descriptors and there is no workaround) to proc_open (CLOEXEC set on all descriptors), needed so close and rename doesn't hang forever if a child (prefetcher) is forked Comment: <pre> +# pclose( $this->handle ); </pre> Leftover debugging code or something? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
