User "Platonides" changed the status of MediaWiki.r96275. Old Status: new New Status: fixme
User "Platonides" also posted a comment on MediaWiki.r96275. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96275#c21938 Commit summary: Fixes for r95260: * Use protected instead of var * Move documentation of closeRenameAndReopen() to parent class. Add a TODO for the other undocumented methods introduced in r95260 * Use the correct method name in the exceptions by using __METHOD__; messages were copypasted from one method to the other without changing anything. Also fix a typo ("argumnts") * Minor coding style bit, will commit more style fixes in a minute Comment: Fatal error: Access level to DumpPipeOutput::$filename must be public (as in class DumpFileOutput) in ./includes/Export.php on line 870 (wasn't a hook supposed to be in place now?) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
