User "^demon" changed the status of MediaWiki.r96352. Old Status: new New Status: fixme
User "^demon" also posted a comment on MediaWiki.r96352. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96352#c21987 Commit summary: fix for r96167 title hack Comment: Couple of notes: * By using <tt>wfMsg()</tt>, you'll be replacing the link into the message ''before'' transforming it, and you'll mangle the link. You should use <tt>wfMsgExt( $key, 'replaceafter', $link )</tt> like I suggested before. * Rather than doing <tt><a></tt> by hand, you should use Linker::link() ** Also with the link: are you sure "[[MobileFrontend Extension Feedback]]" is a valid page on all wikis? It would make sense to make this configurable per-language in a msg (like <tt>'mobile-frontend-feedback-page' => 'Project:Mobile Extension Feedback'</tt> with a <tt>wfMsgNoTrans()</tt>) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
