User "Krinkle" changed the status of MediaWiki.r93269. Old Status: new New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r93269. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93269#c22000 Commit summary: Fix toc margin in modern skin per DieBuche on r90743 Comment: Right now the style looks like this in modern/main.css: <pre> #toc ul, .toc ul { list-style-type: none; list-style-image: none; margin: 0 1em; padding: 0; text-align: left; } .mw-content-ltr .toc ul, .mw-content-rtl .toc ul, .mw-content-ltr #toc ul, .mw-content-rtl #toc ul { margin: 0 1em; } </pre> Why was this fix needed exactly ? The mentioned revision didn't touch modern/main.css, so I' assuming this is a breakage that is being patched here. Please explain the breakage, it likely affects other styles as well. I do not understand what this fix does though, it looks very wrong. The margin is both on the left AND right side, directionality should not play any role here. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
