User "^demon" posted a comment on MediaWiki.r90858. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90858#c22003 Commit summary:
Make parser->getFunctionLang be dependent on title->getPageLanguage() instead of $wgContLang, i.e. the page content language instead of the wiki content language. This sets the right language on page view + edit for all pages, instead of only edit preview on MediaWiki namespace pages (as in EditPage.php). Comment: You could throw an exception. Like Brion said, it probably makes the most sense to die in scenarios where we don't have a title. An exception avoids the E_FATAL and provides a nice usable stack trace. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
