User "Catrope" posted a comment on MediaWiki.r91159.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91159#c22039
Commit summary:
Expand on r91123 Article refactoring:
* Added $user param to relevant WikiPage functions (with b/c)
* Cleaned up editUpdates() signature and tweaked three other WikiPage functions
signatures (with b/c)
* Added fixme to prepareTextForEdit()
Comment:
<pre>
+ public function editUpdates(
+ $text, $summary, $minoredit, $timestamp_of_pagechange, $newid,
+ $changed = true, User $user = null, $created = false
+ ) {
+ global $wgUser;
+ return $this->doEditUpdates( $text, $wgUser, $summary,
$minoredit, $newid, $changed, $created );
</pre>
Shouldn't this use <code>$user</code> if not null?
OK otherwise.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
