User "Bryan" changed the status of MediaWiki.r92279. Old Status: new New Status: fixme
User "Bryan" also posted a comment on MediaWiki.r92279. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92279#c22110 Commit summary: (bug 28762) Resizing to specified height broken for very thin images Restructure and comment of ImageHandler::normaliseParams(). ImageHandler::normaliseParams() will now output both width/height as physicalWidth/Height, where width/height are the dimensions used by the browser, and physicalWidth/Height are the dimensions of the thumbnail that will be created. This allows keeping the use of unique dimensions for a specified thumbnail width, by forcing client side resizing of 1px-wide images with non corresponding height. Also fixed a bug where the check for mustRender() was in an if statement where it should not have been. Comment: That's definitely wrong, see bug 30640. This bug also has a patch, but I think there should be proper unit tests as well. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
