User "Krinkle" changed the status of MediaWiki.r96509. Old Status: new New Status: ok
User "Krinkle" also posted a comment on MediaWiki.r96509. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96509#c22122 Commit summary: Followup to r86108, r86854, r96384: table sorter fetch of 'data-sort-value' attribute failed on IE 6/7 due to directly using DOM methods not available in those browsers. hasAttribute and getAttribute don't appear until IE 8 in Microsoft-land; switching to jQuery's .attr() resolves this nicely. Comment: I thought it was using jQuery already. Duh! All green again :) http://toolserver.org/~krinkle/testswarm/job/355/ _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
