User "Krinkle" posted a comment on MediaWiki.r96509. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96509#c22123 Commit summary:
Followup to r86108, r86854, r96384: table sorter fetch of 'data-sort-value' attribute failed on IE 6/7 due to directly using DOM methods not available in those browsers. hasAttribute and getAttribute don't appear until IE 8 in Microsoft-land; switching to jQuery's .attr() resolves this nicely. Comment: btw, other code is using .data( 'sort-value' ). That's the way it should be accessed. For now no difference, but for the future, using attributes might not work as expected (as they are only read from on initialization to populate the .data ) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
