User "Bawolff" posted a comment on MediaWiki.r91561. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91561#c22130 Commit summary:
(Bug 19725) Do not include suppressed edits in the "View X deleted edits" message, and when doing prefix search of special:undelete. I'm not 100% sure this is the right thing to do, see the bug for the details. But basically this doesn't include an edit in the count if its text is hidden and its hidden from admins. (Not sure if it should not be included only if everything is hidden). Its also weird to show people different things depending if they have suppress rights, without really indicating that. Minor db note: This causes the query to no longer use a covering index. I don't think that matters but just thought i'd mention. p.s. The upload page show deleted edits link is broken right now, (from before) I'll fix in a follow-up. Comment: however listAllPages is never called, so it doesn't matter, but still for code making logical sense is should be in listPages. However I'll wait on committing a follow up until we sort out the other issue, since the other issue quite likely might result in reverting this anyways. In reply to: <pre> If we are ignoring suppressed revs from the deleted rev count, then they should also be visually hidden from sp:undelete or it's inconsistent. But if they are hidden at Undelete, they would still reappear as stubs (all greyed out) on restore, which is surprising to users. So you then have hide suppressed revisions from the history pages of live pages too. </pre> That's basically why I said "I'm not 100% sure this is the right thing to do" in the commit summary. I still think its a good idea to show greyed out stubs for oversighted things. People wanted the ability to make the "view X deleted revisions" to go away when oversighting pages with sensitive titles. Making the view X deleted revisions only count non-oversighted revisions seemed like a possible compromise, allowing hiding a page name ever existed, while still showing the relevant list of (grey-ed out) deleted revisions. After all if there is 3 revisions, and one has been revdeleted, the user can really only view 2 of them. I'm not really attached to this revision, and wouldn't object to it being reverted on the basis of it being a bad idea (if you think doing this is a bad idea that is). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
