User "Thelema314" posted a comment on MediaWiki.r87934.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87934#c22146
Commit summary:
This updates improves the MathML support of texvc. New new tags have
been added, but the parser now recognizes numbers containing decimal
points as being renderable using <mn>. The delimiters (,[,{ now render
using <mo> tags, this allows for equations such as "y=f(x)" to be
rendered to MathML. Finally for standard functions such as \sin, now
render as <mi>\sin</mi>⁡, etc so standard function names
are supported.
Comment:
As far as I can tell, these parameters get used for each different things
scattered around the code. I totally agree that this code should could be
better commented with explanation of what's going on. If the values should be
labeled, ocaml provides records, which work like the tuples being used but have
named access to fields (instead of positional access). The first step to
making this change would be to replace
+ | MHTMLABLEFC of font_class * string * string * math_class * string *
string
with
type mhtmlablefc_t = { font_class: font_class;
string1: string;
string2: string;
math_class: math_class;
string3: string;
string4: string; }
...
+ | MHTMLABLEFC of mhtmlablefc_t
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
