User "Nikerabbit" posted a comment on MediaWiki.r95921. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95921#c22152 Commit summary:
(bug 4381) Magic quotes cleaning is not comprehensive, key strings not unescaped Comment: Code is written once, but read many times. Currently it is difficult to understand. Used to modify behaviour What behavior? And "Used to" is ambiguous construction. Would it be clearer to swap this condition: -!$recursion ? stripslashes( $key ) : $key; + $recursion ? $key : stripslashes( $key ); Although I still don't understand why the key doesn't need to be stripped always. Maybe examples and tests could help? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
