User "Platonides" posted a comment on MediaWiki.r92962. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92962#c22201 Commit summary:
It is stupid to test that a void method returns null. Add a comment explaining that what we are testing is actually the function existence (see r91123 summary) Change the onArticle* to is_callable()s, so that a db is not needed. Comment: I think that assertTrue() is newer than assertEquals(). Not sure which version I was using in July or if I tried to keep BC compatibility. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
