User "^demon" changed the status of MediaWiki.r96645. Old Status: new New Status: ok
User "^demon" also posted a comment on MediaWiki.r96645. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96645#c22218 Commit summary: * Added a script to reduce disk space on a MySQL parser cache setup such as the one at Wikimedia at the moment, by removing all objects which expire before a given time. * Fixed unintentional shortcut evaluation in MultiWriteBagOStuff::doWrite(). It would have caused writes to be skipped on the second cache if the first cache failed, now writes should be attempted on all caches. Comment: Looks good. One minor nitpick: <pre> + $this->addDescription( "Remove old objects from the parser cache. " . + "This only works when the parser cache is in an SQL database." ); </pre> The convention is to set $mDescription. To be honest, I'm not entirely sure why Mark introduced it in r71749...nothing uses it in core or extensions until this rev. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
