User "Bawolff" posted a comment on MediaWiki.r96643.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96643#c22248
Commit summary:

Some of the english translations for our exif-orientation-X messages were wrong 
(CW instead of CCW, vice versa).

Do these types of changes need release-notes?

Comment:

I uploaded the potrait-rotated.jpg image from the phpunit tests to my test wiki 
and noticed the orientation tag looked wrong. I then had a conversation with 
some nice folks on #wikimedia-commons to see if it was wrong or I was just 
loosing my mind ;)

As an aside, exiftool uses labels like "Rotate 270 CW" for orientation 8, 
presumably this means it needs to be rotated that way to fix the orientation, 
where we're using rotat'''ed''' which should logically mean what has already 
been done to the image to get it to the current state. That's possibly where 
the confusion has sprung up. This distinction doesn't matter for the other 
orientation tags, since those operations are their own inverse.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to