User "Brion VIBBER" posted a comment on MediaWiki.r87986. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87986#c22277 Commit summary:
(reverts r87985, and does what that was SUPPOSED to do!) Gerenalized code used in 2 places for adding scripts to the body, and switched from using jQuery.getScript to direct DOM manipulation to avoid jQuery running script file contents through eval, which caused insane line numbers when errors occured. Comment: As a happy side effect, using the raw DOM append here (thus skipping some weird hidden behavior of jQuery where its .append() etc actually end up loading scripts through $.evalScript) this also fixes bug 30825. Needs backport to 1.17wmf1. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
