User "Aaron Schulz" changed the status of MediaWiki.r96687. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r96687. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96687#c22290 Commit summary: (bug 30640; follow-up r92279) Rotating images was making skewed images This is Bryan's patch from bug 30640 with a couple minor related changes, plus some unit tests. This also addresses an issue with preventing too-big images from being scaled from r92279. I also noticed that image magick's rotation support is broken in 6.3.7 (the version I had installed locally. I've since upgraded) I'm not sure if we should be doing something about that... I did test this without both image magick, and gd (although only very briefly with gd) both seemed to work well. I didn't test any other image scalars. Comment: The logic here is a lot easier to follow now. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
