User "Jack Phoenix" posted a comment on MediaWiki.r96704. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96704#c22296 Commit summary:
need to have extensions on the files being transformed, and put in some checks for transform failure. Comment: <pre> + @unlink( $thumbPath ); </pre> @ is evil, use wfSuppressWarnings(); and wfRestoreWarnings(); instead; see [[Manual:Coding conventions#Error handling]] for details. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
