User "Platonides" posted a comment on MediaWiki.r96306. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96306#c22318 Commit summary:
Revert r88008 (add size difference to Special:Contributions) and its large group of friends, they break Special:Contributions by joining against recentchanges and dropping any contribs that have fallen off RC. See also CR discussion at r95496, which was Sam's incomplete attempt at reverting this. Follow-ups reverted: r88019, r88024, r88111, r88117, r88252, r96081. Left the parts of r88025 and r88026 (everything except the MessagesEn.php change) that disable the namespace filter in miser mode intact; that was a good change and not really related to the r88008 other than that it touched nearby code. Comment: Heh, no problem with that. In fact, it may be preferable to start it again, given its convoluted history (from reading r95496). They mention the LEFT JOIN but wasn't done. It striked me, as the description "joining against recentchanges and dropping any contribs that have fallen off RC" points clearly to an INNER JOIN that should have been LEFT. Good that more work on this is welcome, but I'm not able to dedicate it time right now. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
