User "Siebrand" posted a comment on MediaWiki.r96798.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96798#c22349
Commit summary:
(Bug 30364) LanguageConverter should depend on the page content language
instead of the wiki content language. Remains largely the same, except for
extensions using the PageContentLanguage hook like Translate and
WikimediaIncubator.
* Made variant tabs hidden on special pages (has no or sometimes
wrong/inconsistent effect there; plus it's mainly in the user language)
* Made redirects be in content language again (remove from
Title->getPageLanguage())
Comment:
<code>- if ( $req ) {
+ if ( $req = $this->validateVariant( $req ) ) {
</code>
Afaik assignments inside ifs should be avoided.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
