User "Duplicatebug" posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c22352 Commit summary:
Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: This commit makes Title.php mutable (with Title::setInterwiki), it is called at one place, maybe it is possible to create a new title with one of the factory methods and remove Title::setInterwiki. The change of Preprocessor_Hash.php should also added to Preprocessor_HipHop. A comment is also nice, to say why the interwiki of the frame/context, and not the interwiki from the templatename, is used. (My understanding: It is used to load the inner templates of a distant template also from the distant wiki). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
