User "Catrope" changed the status of MediaWiki.r96759. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96759 Commit summary: [ResourceLoader2] Address issues raised in r96309 CR * Ensure (partial) classname is escaped when generating HTML instead of requiring the input to be safe. Although the input is from developers (not from users), it's not obvious when calling the function that it requires escaping beforehand. * Adding $ as first argument in the closure and calling it with jQuery * Fix typo in the documentation * Improve documentation (listing callback arguments) * Wrote documentation for newPropHtml() * Removed the automatic separation of the prefix with a dash. People can provide this themselves if wanted. A good default is given. * Letting the plugin maintain the 'props' object, instead of leaving it up to the callback. This removes a lot of code duplication and removes the need for users to implement their own "arrayRemove"-function, moved this utility into the plugin. * Calling .splice() before the looping over json.query.gadgetpages (since the array will become shorter, less items to loop over) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
