User "Catrope" changed the status of MediaWiki.r96934. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r96934. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96934#c22427 Commit summary: If the scaler URL is protocol-relative, things just break here. Sets a sane default. Comment: <pre> + if( preg_match( '/^\/\//', $scalerBaseUrl ) ) { + // this is apparently a protocol-relative URL, which makes no sense in this context, + // since this is used for communication that's internal to the application. + // default to http. + $scalerBaseUrl = 'http:' . $scalerBaseUrl; + } </pre> We have a utility function for that: <code>wfExpandUrl( $scalerBaseUrl, PROTO_HTTP );</code> . To address the other comments, you might use <code>PROTO_CANONICAL</code> instead so the protocol of <code>$wgCanonicalServer</code> is used. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
