User "Reedy" posted a comment on MediaWiki.r89220.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89220#c22432
Commit summary:
Remove Cite singleton. Store it inside each associated parser at
$parser->extCite
This fixes bug 20748 and bug 15819 without breaking the other tests. Reverts
r88971.
The conflict with CategoryTree was the old problem of a message being called
inside
of a parser callback, this time with clearState for which the hook is global.
Comment:
<pre>
wfRunHooks( 'ParserBeforeTidy', array( &$this, &$text ) );
wfRunHooks( 'ParserClearState', array( &$this ) );
</pre>
Neither of those have changed in many many thousands of revisions... I see
clearState has $parser instead of &$parser, and seemingly could be updated
without any issue
Fixing the definitions and calls is easy enough.
What exactly needs doing to clear this all up?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
