User "Aaron Schulz" changed the status of MediaWiki.r86814. Old Status: new New Status: ok
User "Aaron Schulz" also posted a comment on MediaWiki.r86814. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86814#c22475 Commit summary: Beginnings of a rewrite of the captcha system in a more object-oriented fashion; currently although there are classes for different types of captcha, they don't actually represent a single captcha object, they're just confused frontend/backend messes. With the places captchas are inserted increasingly using HTMLForm, it makes eminent sense to introduce a HTMLCaptchaField, but that needs a more OOP implementation of the actual captcha, which I've started here. This is not finished and isn't actually implemented anywhere, but a) it's harmless, b) I don't want it to bitrot, and c) some feedback would always be appreciated, so here it is. Comment: More or less OK. Not sure where getApiParams() is going. The WebRequest thing stood out to me too, but I see why that's hard to work around. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
