User "Tim Starling" changed the status of MediaWiki.r86304. Old Status: new New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r86304. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86304#c22522 Commit summary: * (bug 28532) wfMsgExt() and wfMsgWikiHtml() use $wgOut->parse() * (bug 16129) Transcluded special pages expose strip markers when they output parsed messages Also adding some related documentation during my travels around the code Comment: MessageCache::parse() is not tolerant of $wgTitle being null, which was one of the main complaints in bug 28532. Compare with Parser::transformMsg(): <pre> if ( !$title ) { global $wgTitle; $title = $wgTitle; } if ( !$title ) { # It's not uncommon having a null $wgTitle in scripts. See r80898 # Create a ghost title in such case $title = Title::newFromText( 'Dwimmerlaik' ); } </pre> We need something like this in MessageCache::parse(). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
