User "^demon" changed the status of MediaWiki.r94465. Old Status: new New Status: fixme
User "^demon" also posted a comment on MediaWiki.r94465. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94465#c22553 Commit summary: Add code to the sanitizer to convert presontational attributes that were removed in html5 into inline css. This allows wiki to keep using them in short loose WikiText but still output valid modern markup. Note that there were some attributes excluded. Namely stuff on img and object, and the table cellspacing and cellpading which aren't easily converted into inline css. Comment: * Needs tests * Sanitizer:: fixDeprecatedAttributes() shouldn't check the global, callers should be responsible for checking. * [[Manual:Coding_conventions#PHP_pitfalls|Don't use <tt>empty()</tt>]], a weak boolean check on $style should be sufficient. If you're super paranoid, use <tt>$empty !== ""</tt> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
