User "Brion VIBBER" posted a comment on MediaWiki.r96958. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96958#c22558 Commit summary:
* Use local context instead of global variables * Pass the context to the HTMLForm object Comment: Seems to be a non-required update for an internal API change in 1.18 (r85957), which isn't clearly marked in the doc comments for the HTMLForm constructor. If a string is passed as the second parameter (which used to be $messagePrefix but is now $context), then the function internally rearranges to the new order of parameters. IMO this isn't a super great kind of API change as it looks confusing; optional parameters in the middle of a list are dangerous! _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
