User "Nikerabbit" changed the status of MediaWiki.r97098. Old Status: new New Status: ok
User "Nikerabbit" also posted a comment on MediaWiki.r97098. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97098#c22567 Commit summary: * (bug 30900) Remove confusing default value added for the default-don't-say-anything case of searchmenu-new-nocreate message Reverts r80746's addition of a default value, removal of the message from the 'ignore' list, and the subsequent translations of this message that's supposed to be empty. It doesn't make sense to have a default value here; as added in r65902 it was meant to default to empty. It's not very well thought out to begin with, so any message that goes it ends up being confusing. For queries that aren't meant to be page titles it's meaningless to begin with, and for users who aren't allowed to create articles at all due to read-only or edit/create restrictions it's even more confusing. Comment: These messages need to be deleted from twn too, to fix the bug there. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
