User "Tim Starling" posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c22569 Commit summary:
Comment: I'm backing this out for 1.18. Constructing a structured representation of the input text and then transforming it to HTML as a second step is an approach which has a very high memory overhead, and a moderately high CPU overhead. It should only be used as a last resort, where on-the-fly generation of output text is not feasible. It does appear to be feasible in this case -- in fact the main desired feature, adding of <thead> elements, should be possible with just a few extra lines in the old doTableStuff(). I'm also concerned about the number of unintended changes in the input syntax and output. Many were fixed, but at least bug 30746 remains. The lack of attention to backwards compatibility implied by these changes indicates that deployment may uncover further issues which affect our large existing text corpus. A rewrite is fine in principle, since the code is old and ugly. But the behaviour should be made as close as possible to the old code, to enable differential fuzz testing to be done, and the overall design should take performance into account. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
