User "Awjrichards" changed the status of MediaWiki.r97009.

Old Status: new
New Status: fixme

User "Awjrichards" also posted a comment on MediaWiki.r97009.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97009#c22606
Commit summary:

Adding new RapidHTML forms (including css/js folders)

Comment:

>From 
>trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/lp1.css:
<pre>
+ background-image: 
url(http://upload.wikimedia.org/wikipedia/foundation/d/dc/Jimmy_Appeal_2009.jpg);
</pre>
Two problems here - it's not being loaded via https and it's an external 
resource that someone else could potentially mess with and conceivably turn 
into a malicious resource.

Also, please unminify JS so it can be properly reviewed.


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to