User "Brion VIBBER" changed the status of MediaWiki.r89220. Old Status: new New Status: ok
User "Brion VIBBER" also posted a comment on MediaWiki.r89220. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89220#c22616 Commit summary: Remove Cite singleton. Store it inside each associated parser at $parser->extCite This fixes bug 20748 and bug 15819 without breaking the other tests. Reverts r88971. The conflict with CategoryTree was the old problem of a message being called inside of a parser callback, this time with clearState for which the hook is global. Comment: Marking this OK since there doesn't seem to be any active breakage; but I still recommend swapping these out for static forwarder methods. I might get to it in a bit as general code cleanup, or someone else might get to it later. :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
