User "Krinkle" posted a comment on MediaWiki.r90902.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90902#c22714
Commit summary:

* (bug 28259) Localise CR Tooltips

Comment:

Although it's no longer in trunk, the following caused a uncaught exception in 
the Installer of 1.17.0 when trying to install CodeReview, because the 
CodeRevision class wasn't autoloaded (obviously)
<pre>
 // Revision tooltips CodeRevisionView:
 $wgResourceModules['ext.codereview.tooltips'] = array(
        'scripts' => 'ext.codereview.tooltips.js',
-       'dependencies' => 'jquery.tipsy'
+       'dependencies' => 'jquery.tipsy',
+       'messages' => array_merge( CodeRevision::getPossibleStateMessageKeys(), 
array( 'code-tooltip-withsummary', 'code-tooltip-withoutsummary' ) ),
</pre>

The setup just crashed/stopped after it includes CodeReview.php.
The following was temporary hack to fix it.
<pre>
+require_once($dir . 'backend/CodeRevision.php'); # KrinkleDev local hack. Used 
below
</pre>

Fixed by r95644

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to