User "Xqt" posted a comment on pywikipedia.r9525.

Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9525#c22732
Commit summary:

Use BeautifulSoup for getting HTML links and images.

 Removed simplistic regular expression based guessing
 of contents of src="" and href="" attributes.
 Still, treating all URLs ending with '.jpeg' or similar
 is unsuitable for fetching images from MediaWiki
 installations, since /wiki/File:Picture.jpg links are
 pointing to the description pages, not the pictures
 themselves.

Comment:

Never mix spaces and tabs in the same file, it may cause indentation errors 
(PEP 8 style guide)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to