User "Reedy" posted a comment on MediaWiki.r97551.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97551#c22814
Commit summary:

Don't try and delete ForeignAPIFile or ForeignDBFile

Add a space before the error message so it's not cramped up next to the page 
name

Add a success error message (explicit is better than guessing)

Comment:

<pre>
        function isLocal() {
                $repo = $this->getRepo();
                return $repo && $repo->isLocal();
        }
</pre>

That'd be saner

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to